Skip to content

[OP-182] Fix dependency pinning errors: package-lock.json / npm ci #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clackwork wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[OP-182] Fix dependency pinning errors: package-lock.json / npm ci #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
node_modules
package_lock.json
package-lock.json
iXBRLViewerPlugin/viewer/*.xhtml
iXBRLViewerPlugin/viewer/dist/ixbrlviewer.dev.js
iXBRLViewerPlugin/viewer/font
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@ ADD . /build/

# The following command replaces the @VERSION@ string in setup.py and package.json
# with the tagged version number from GIT_TAG or `0.0.0` if GIT_TAG is not set
# package-lock.json is also updated
ARG VERSION=${GIT_TAG:-0.0.0}
RUN echo "Version = $VERSION"
# Update line 6 in setup.py
RUN sed -i "6 s/0.0.0/$VERSION/" setup.py
# Update line 3 in package.json
RUN sed -i "3 s/0.0.0/$VERSION/" package.json
RUN npm version $VERSION --no-git-tag-version

# build ixbrlviewer.js
RUN apt-get update && apt-get install -y curl && \
curl -sL https://deb.nodesource.com/setup_10.x | bash && \
apt-get install -y nodejs build-essential
RUN npm install
RUN npm ci
RUN make prod

# javascript tests
Expand Down
Loading
Loading