Skip to content

Add pyproject.toml for Custom Node Registry#2

Open
haohaocreates wants to merge 1 commit into
prozacgod:masterfrom
haohaocreates:pyproject
Open

Add pyproject.toml for Custom Node Registry#2
haohaocreates wants to merge 1 commit into
prozacgod:masterfrom
haohaocreates:pyproject

Conversation

@haohaocreates

@haohaocreates haohaocreates commented May 22, 2024

Copy link
Copy Markdown

We are building a global registry for custom nodes (similar to PyPI). The registry makes using custom nodes more reliable by reserving globally unique names for each custom node, and supporting semantic versioning.

Here’s some more information on the registry.

Action Required:

  • Go to the registry. Login and create a publisher id. Comment it here and we will update the PR (or just merge it and change it yourself).
  • Write a short the description.
  • Merge the separate Github Actions PR and run the workflow.
    If you want to publish the node manually, install the cli and run comfy node publish

Please message me on Discord if you have any questions!

@haohaocreates

Copy link
Copy Markdown
Author

hey @prozacgod, wanted to send a small nudge and ask if you had any questions!

@prozacgod

Copy link
Copy Markdown
Owner

Hey! thanks for the nudge, should I add an icon, and a author id into the toml?

@prozacgod

Copy link
Copy Markdown
Owner

Upon review, I didn't mind logging into a webpage and hitting a button, but I'm wary of a "cold call merge request, that requires a CLI tool". It feels very 'red-flag' to me to install something locally upon request of a third party.

@haohaocreates

haohaocreates commented Jun 21, 2024 via email

Copy link
Copy Markdown
Author

@haohaocreates

Copy link
Copy Markdown
Author

Upon review, I didn't mind logging into a webpage and hitting a button, but I'm wary of a "cold call merge request, that requires a CLI tool". It feels very 'red-flag' to me to install something locally upon request of a third party.

on another note just wanted to add a small pointer! it's not actually mandatory to install the CLI, we only suggest it as a manual option for users who don't feel comfortable setting up the Github Action. The entire node publishing process can be done through the Github Action in the other PR and updating the pyproject.toml file in this PR.

@haohaocreates

Copy link
Copy Markdown
Author

hey @prozacgod , everything ok on your end! just wanted to check up see if there was anything I could help with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants