Add pyproject.toml for Custom Node Registry#2
Conversation
|
hey @prozacgod, wanted to send a small nudge and ask if you had any questions! |
|
Hey! thanks for the nudge, should I add an icon, and a author id into the toml? |
|
Upon review, I didn't mind logging into a webpage and hitting a button, but I'm wary of a "cold call merge request, that requires a CLI tool". It feels very 'red-flag' to me to install something locally upon request of a third party. |
|
Hey Prozacgod! Totally understandable!
If it helps we are part of comfy-org [Comfy Org <https://www.comfy.org/>]
You might have seen this article already too [The next chapter for ComfyUI
| ComfyUI blog
<https://blog.comfyui.ca/comfyui/update/2024/06/18/Next-Chapter.html>]
Regarding the actual CLI, we ask for permission if authors want to enable
tracking [this just lets node authors see downloads/installs/ratings
regarding their node]. Otherwise, there won't be any information tracked.
Lmk if you have any other questions!
…On Thu, Jun 20, 2024 at 2:33 PM Prozacgod ***@***.***> wrote:
Upon review, I didn't mind logging into a webpage and hitting a button,
but I'm wary of a "cold call merge request, that requires a CLI tool". It
feels very 'red-flag' to me to install something locally upon request of a
third party.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BG3AD2P6DEEABQFXPK7MVHTZIMOATAVCNFSM6AAAAABIERIZICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGI4TSMBVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
on another note just wanted to add a small pointer! it's not actually mandatory to install the CLI, we only suggest it as a manual option for users who don't feel comfortable setting up the Github Action. The entire node publishing process can be done through the Github Action in the other PR and updating the pyproject.toml file in this PR. |
|
hey @prozacgod , everything ok on your end! just wanted to check up see if there was anything I could help with! |
We are building a global registry for custom nodes (similar to PyPI). The registry makes using custom nodes more reliable by reserving globally unique names for each custom node, and supporting semantic versioning.
Here’s some more information on the registry.
Action Required:
If you want to publish the node manually, install the cli and run
comfy node publishPlease message me on Discord if you have any questions!