Skip to content

Commit

Permalink
fix path parsing bug on windows (#14931)
Browse files Browse the repository at this point in the history
Co-authored-by: Kasey Kirkham <[email protected]>
  • Loading branch information
kasey and kasey authored Feb 14, 2025
1 parent 9eff6ae commit e39f44b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 1 addition & 2 deletions beacon-chain/db/filesystem/iteration.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package filesystem
import (
"fmt"
"io"
"path"
"path/filepath"
"strconv"
"strings"
Expand Down Expand Up @@ -193,7 +192,7 @@ func rootFromPath(p string) ([32]byte, error) {
}

func idxFromPath(p string) (uint64, error) {
p = path.Base(p)
p = filepath.Base(p)

if !isSszFile(p) {
return 0, errors.Wrap(errNotBlobSSZ, "does not have .ssz extension")
Expand Down
2 changes: 2 additions & 0 deletions changelog/kasey_windows-layout-fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
### Fixed
- Fixed bug that breaks new blob storage layout code on Windows, caused by accidental use of platform-dependent path parsing package.

0 comments on commit e39f44b

Please sign in to comment.