Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path parsing bug on windows #14931

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix path parsing bug on windows #14931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions beacon-chain/db/filesystem/iteration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package filesystem
import (
"fmt"
"io"
"path"
"path/filepath"
"strconv"
"strings"
Expand Down Expand Up @@ -193,7 +192,7 @@ func rootFromPath(p string) ([32]byte, error) {
}

func idxFromPath(p string) (uint64, error) {
p = path.Base(p)
p = filepath.Base(p)

if !isSszFile(p) {
return 0, errors.Wrap(errNotBlobSSZ, "does not have .ssz extension")
Expand Down
2 changes: 2 additions & 0 deletions changelog/kasey_windows-layout-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
### Fixed
- Fixed bug that breaks new blob storage layout code on Windows, caused by accidental use of platform-dependent path parsing package.
Loading