Inline pre-commit linting#7539
Merged
Merged
Conversation
nateprewitt
commented
Jun 24, 2026
| - name: Run pre-commit | ||
| uses: pre-commit/action@646c83fcd040023954eafda54b4db0192ce70507 # v3.0.0 | ||
| run: | | ||
| python -m pip install pre-commit==4.6.0 |
Member
Author
There was a problem hiding this comment.
We could add this to a dependency group or in a requirements file. I'm not sure it's important/needed though, and I'd rather not add another requirements setup to manage.
sigmavirus24
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves us off of https://github.com/pre-commit/action to running pre-commit directly. This should avoid the transitive dependency pinning issues from #7536.
I've also reduced our pin update frequency for
pre-committo minor versions since we're getting weekly dependabot updates that aren't necessary. This matches our existing constraints for other ecosystems.