ci: add PHP debug build job#33
Merged
Merged
Conversation
The debug PHP build runs Zend's refcount invariants and a leak detector at shutdown. Release builds silently let those bugs through, as we just saw with the #[php(prop)] String getter leak on Exception::getMessage. continue-on-error is on during initial rollout so unrelated PHP-internal asserts on bleeding-edge versions do not block PRs. Will flip to false once we have a few clean runs.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
tests-debugjob that runs PHPUnit against a PHP debug build. The debug build enables Zend's refcount invariants and the leak detector at shutdown, which catches FFI refcount mistakes that release builds silently let through.Spotted while tracing the
DatalogException::getMessageleak: the release matrix passed, the bug only surfaced because I happened to be on a local PHP 8.5-dev debug build. With this job we would have caught it in CI.Runs on PHP 8.5 with
continue-on-error: truefor the initial rollout so unrelated bleeding-edge asserts do not block PRs. Flip to false once we trust the signal.