Fix delete test failure in hub environment (#71)#122
Closed
scion-gteam[bot] wants to merge 1 commit into
Closed
Conversation
Also unset SCION_PROJECT_ID when clearing hub context env vars, since IsHubContext() checks all four env vars and a leftover SCION_PROJECT_ID causes FindProjectRoot() to return a synthetic path instead of failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestDeleteStopped_RequiresGroveContextfailing whenSCION_PROJECT_IDis set in the environment (e.g., inside hub-connected containers)SCION_HUB_ENDPOINT,SCION_HUB_URL, andSCION_GROVE_IDto disable hub context detection, butIsHubContext()also checksSCION_PROJECT_ID— the missing unset causedFindProjectRoot()to return a synthetic path instead of failing, leading to a Docker call that errors in environments without DockerRefs #71
Test plan
go test ./cmd/...passesgo test ./pkg/hub/...passesTestDeleteStopped_RequiresGroveContextpasses in isolationTestDeleteStopped_AcceptsGlobalFlagstill passes