Fix agent list task overflow and unify action buttons#136
Closed
scion-gteam[bot] wants to merge 3 commits into
Closed
Fix agent list task overflow and unify action buttons#136scion-gteam[bot] wants to merge 3 commits into
scion-gteam[bot] wants to merge 3 commits into
Conversation
Task cell in list view used inline span styling that silently ignored max-width/overflow constraints, allowing long task text to push action buttons off-screen. Switch to display:-webkit-box with line-clamp:2 so text wraps to at most two lines with ellipsis. Card view action buttons now render icon-only (matching list view), with sl-tooltip and aria-label for accessibility. Both views share a single renderActionButtons helper, eliminating the duplicated button logic. Color-coded hover effects added to action buttons in both views: red for stop/delete, amber for suspend, green for resume/start. Closes #134 Closes #135
Task cell in list view used inline span styling that silently ignored max-width/overflow constraints, allowing long task text to push action buttons off-screen. Switch to display:-webkit-box with line-clamp:2 so text wraps to at most two lines with ellipsis. Card view action buttons now render icon-only (matching list view), with sl-tooltip and aria-label for accessibility. Both views share a single renderActionButtons helper, eliminating the duplicated button logic. Color-coded hover effects use translucent rgba backgrounds that work in both light and dark mode: red for stop/delete, amber for suspend, green for resume/start. Closes #134 Closes #135
Screenshots captured from the real running app (Vite dev server + fetch mock for agent data). Shows before/after for both issues in light mode and dark mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.task-cellin list view was rendered as a<span>(inline element), causingmax-width/overflow/text-overflowto be silently ignored. Long task text pushed action buttons off-screen. Fixed by switching todisplay: -webkit-boxwith-webkit-line-clamp: 2so text wraps to at most two lines with ellipsis.<sl-tooltip>andaria-labeladded for accessibility.::part(base):hoverto style Shoelace shadow DOM internals. Hover backgrounds use translucentrgba()values that work correctly in both light and dark mode.renderActionButtons()helper, eliminating duplicated button-rendering logic betweenrenderAgentCardandrenderAgentRow.Files changed
web/src/components/shared/resource-styles.ts—.task-cellCSS fix (line-clamp)web/src/components/pages/agents.ts— shared button helper, hover CSS, card/row refactorBuild & lint
npm run typecheck— passesnpm run build— passesnpm run lint— pre-existing lint errors only; no new errors introducedScreenshots
All screenshots captured from the real running Scion web app (Vite dev server with fetch-intercepted mock agent data).
Before — Card view with text labels
Before — List view: task text overflows, actions pushed off-screen
After — Card view: icon-only buttons with tooltips
After — List view: task clamped to 2 lines, actions visible
Hover — Card view tooltip ("Suspend")
Hover — List view tooltip ("Stop")
Dark mode — Card view
Dark mode — List view
Test plan
Closes #134
Closes #135