Skip to content

Conversation

@hitzemann
Copy link
Contributor

I discovered typst and your modern-cv lib today. I found the need for adding my signature above my name in the signature block of the cover letter.
I tried adding a type check, but that broke adding the image.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds functionality to include an author's signature image in the cover letter signature block. The image appears above the author's name when the signature field is provided in the author object.

  • Adds a new signature parameter to the function signature with type image
  • Implements conditional rendering of the signature image in the signature block

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Owner

@ptsouchlos ptsouchlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment - lmk your thoughts and thanks for the PR!

@hitzemann
Copy link
Contributor Author

Looks all good to me, I think copilot was confused by "signature" being the name of the key in the object and the name of a function at the same time.

@ptsouchlos
Copy link
Owner

LGTM thanks again!

@ptsouchlos ptsouchlos merged commit b15709f into ptsouchlos:main Sep 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants