fix: Icons and their text can get separated by automatic linebreaking

[paulrauecker]

I wrapped the contacts into additional boxes to ensure icons stay with text, as sometimes there would be inconvenient linebreaks in the CV. I also made the separator usage a bit more consistent, in a way similar to #82 as I just noticed-

[ptsouchlos]

Thanks for this! I'll give it a more thorough review hopefully in the next week or so but with a cursory look, it looks good to me. Might be good to consider adding test cases for the elements that consist of icon + text so that we can detect breaking changes as part of the testing suite.

[ptsouchlos]

Overall this looks good, when when I build the resume sample template, the icons appear like this in the header:

Do you see the same? If so, we need to address the spacing between the icon and associated text before merging this.

[ptsouchlos]

I think I have a solution to what I commented above. I'll push some changes.

[paulrauecker]

It looks like this for me, both locally and in the webeditor, with no visual change except the linkedin icon getting pushed into the 2nd line

[paulrauecker]

It's surely a matter of taste, but I also aligned the contacts block by horizon, to get more consistent spacing, and set the alignment for each contact box to bottom. Would you like me to push those changes as well?

[ptsouchlos]

It's surely a matter of taste, but I also aligned the contacts block by horizon, to get more consistent spacing, and set the alignment for each contact box to bottom. Would you like me to push those changes as well?

I like this more actually, please go ahead and push these changes. Thanks for you help!

[paulrauecker]

Gladly, thank you for the great template!

[ptsouchlos]

Hmm for me there's still a bit of overlap, but this is present for me even with the released version of the template, so it's likely on my end. Just curious, but what version of typst do you have @paulrauecker ?

[paulrauecker]

typst 0.14.0 (dd1e6e94) locally and Typst 0.14.0 on the webapp
seem like i can quickly change the version on the webapp, so it looks like it also works fine on the Development to 0.10.0 versions

[paulrauecker]

[15:32:26] compiled with warnings in 55.34 ms

warning: unknown font family: source sans pro
    ┌─ modern-cv/lib.typ:245:10
    │
245 │     font: font,
    │           ^^^^

warning: unknown font family: source sans 3
    ┌─ modern-cv/lib.typ:245:10
    │
245 │     font: font,
    │           ^^^^

warning: unknown font family: roboto
    ┌─ modern-cv/lib.typ:297:55
    │
297 │           #set text(size: 32pt, style: "normal", font: header-font)
    │                                                        ^^^^^^^^^^^

My guess would be that it's a font issue, which i elegantly circumvent by not having them installed. give me a sec and i'll try to fix that. I'm also using Font Awesome 7 in the working dir, i think your README stated 6?

[ptsouchlos]

[15:32:26] compiled with warnings in 55.34 ms

warning: unknown font family: source sans pro
    ┌─ modern-cv/lib.typ:245:10
    │
245 │     font: font,
    │           ^^^^

warning: unknown font family: source sans 3
    ┌─ modern-cv/lib.typ:245:10
    │
245 │     font: font,
    │           ^^^^

warning: unknown font family: roboto
    ┌─ modern-cv/lib.typ:297:55
    │
297 │           #set text(size: 32pt, style: "normal", font: header-font)
    │                                                        ^^^^^^^^^^^

My guess would be that it's a font issue, which i elegantly circumvent by not having them installed. give me a sec and i'll try to fix that. I'm also using Font Awesome 7 in the working dir, i think your README stated 6?

Ah I see, yes you can use the font installation scripts to install them locally. And yes the template still requires fontawesome 6.

[paulrauecker]

[15:48:57] compiled successfully in 65.82 ms
I loaded all the fonts into a local dir, but that still doesn't reproduce the spacing error

[ptsouchlos]

[15:48:57] compiled successfully in 65.82 ms I loaded all the fonts into a local dir, but that still doesn't reproduce the spacing error

Hmm must be something on my end then. I'll look into it separately. Thanks!

[paulrauecker]

The one cause that I can still imagine is that the box somehow breaks in your env. could you try removing one for testing purposes? e.g.

--- a/lib.typ
+++ b/lib.typ
@@ -337,7 +337,7 @@
     let items = ()

     if "birth" in author {
-      items.push(box[
+      items.push([
         #birth-icon
         #box[#text(author.birth)]
       ])

I think we can exclude a pdf viewer issue, i tried chromium, firefox, zathura, okular, the gnome document viewer, and they all render it identically