fix: miscellaneous issues #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 30, 2025 12:28
Xml error deatils parsing for aws s3 provided error for files upload and download operations.
jguz-pubnub
reviewed
Oct 8, 2025
| switch (this) { | ||
| case PushGateway.fcm: | ||
| return 'gcm'; | ||
| return 'fcm'; |
There was a problem hiding this comment.
Is fcm value allowed by the server?
There was a problem hiding this comment.
Isn't that's the real update we needed after decommission of GCM support by Google? Referring this googleblog
There was a problem hiding this comment.
OR am I missing something here!?
There was a problem hiding this comment.
As we tested, the fcm value is allowed
…tched users count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: error handling in files apis.
Fixes issue of not getting proper error details when file upload fails.
fix: unrecoverable subscription.
Fixes issue of no-op when
subscribe()called on inactive or errored subscrption.fix: generate file upload url API.
Fixes issue of generate upload file url to incorporate token when configured or set explicitly.
fix: mapping of gcm push notification gateway to fcm type
Discard use of gcm and replaced with fcm for push notification service type of google.
test: pubnub access manager tests