SharedWorker refactor
#471
Conversation
Decouple and re-organize `SharedWorker` code for better maintainability. perf(shared-worker): improved subscription state refresh logic Additional query parameter (removed before sending) is added for requests triggered by user and state will be updated only for these requests. refactor(logger): avoid similar timestamp in sequential lines Log entry timestamp will be altered on millisecond if multiple log entries have similar timestamp (logged in fraction of nanoseconds).
parfeon
added
priority: medium
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
| if (channelGroups) channelGroups = channelGroups.filter((channelGroup) => !channelGroup.endsWith('-pnpres')); | ||
| if (channels) channels = channels.filter((channel) => !channel.endsWith('-pnpres')); | ||
| } | ||
| if (channelGroups) channelGroups = channelGroups.filter((channelGroup) => !channelGroup.endsWith('-pnpres')); |
There was a problem hiding this comment.
will this be applicable to ee and non ee case both cases? OR it's just for getSubscribedChannels/Groups method?
There was a problem hiding this comment.
This used for REST API call itself. Function used by: SubscriptionManager, PresenceEventEngine and EventEngine (when presence interval not set).
|
@mohitpubnub sure |
…` change Handle the situation when `userId` is changed without proper state changes (unsubscribe, change, and subscribe back). fix(shared-worker): fix subscribe/heartbeat aggregation after `auth` change fix(shared-worker): fix race of conditions with backup timer Fix race of conditions caused by explicit heartbeat on `auth` change and frequency throttling logic, which prevented "backup" timer restart.
| client.addEventListener(PubNubClientEvent.IdentityChange, () => this.moveClient(client), { | ||
| signal: abortController.signal, | ||
| }); | ||
| client.addEventListener( |
There was a problem hiding this comment.
wondering about a case where userId and auth both changed for given subscription then will this new request will contain updated token? along with new userId.
There was a problem hiding this comment.
I mean which event will be triggered PubNubClientEvent.IdentityChange or PubNubClientEvent.AuthChange
There was a problem hiding this comment.
pubnub.setUserId will trigger PubNubClientEvent.IdentityChange and pubnub.setToken() will trigger PubNubClientEvent.AuthChange. But you have me a hint that there is nothing for pubnub.setAuthKey(). Order will be the same as user call those functions.
There was a problem hiding this comment.
@mohitpubnub nm, it will also dispatch PubNubClientEvent.AuthChange.
… next subscribe request takes place only after setToken(). to avoid race condition on checking authtoken vs previous subscribe
Fixed issue when user additionally calls unsubscribe on page unload and it collides with built-in logic, which invalidates PubNub client from closed tab. fix(shared-worker): fix issue that didn't handle properly too early heartbeat Resolved the issue because of which requests that were too early received a response and still have been sent. fix(shared-worker): try to fix client timeout timer throttling Try to resolve issues with timers getting throttled in SharedWorker and actually active PubNub clients being mistakenly evicted from the state and the state reset for it.
Call 'invalidate' in the client manager only if the client removed in response to the timeout timer detected that it is inactive.
| @@ -253,6 +255,7 @@ export class PubNubClientsManager extends EventTarget { | |||
| this.unregisterClient( | |||
| client, | |||
| this.timeouts[client.subKey] ? this.timeouts[client.subKey].unsubscribeOffline : false, | |||
| true, | |||
There was a problem hiding this comment.
👍🏻
this may help with edge case
refactor(shared-worker): reorganize
SharedWorkercodeDecouple and re-organize
SharedWorkercode for better maintainability.perf(shared-worker): improved subscription state refresh logic
Additional query parameter (removed before sending) is added for requests triggered by user and state will be updated only for these requests.
refactor(logger): avoid similar timestamp in sequential lines
Log entry timestamp will be altered on millisecond if multiple log entries have similar timestamp (logged in fraction of nanoseconds).