Skip to content

[DRAFT] Demo TinyViT compatibility with tiled Siracusa #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 78 commits into
base: devel
Choose a base branch
from
Draft

[DRAFT] Demo TinyViT compatibility with tiled Siracusa #124

wants to merge 78 commits into from

Conversation

@diaconuccalin
Copy link
Contributor

@diaconuccalin diaconuccalin commented Oct 16, 2025 •
edited
Loading

Waiting on PR 117.

Added

  • Bias handling for regular and DW Conv2D tiling
  • Float non-requantized DW Conv2D tiling constraints
  • Broadcast support for MatMul tiling constraints
  • ReduceMean and Slice nodes tiling constraints and bindings

Changed

Fixed

  • Input cube computation for tiled DW Conv2D
  • GELU PULPOpen kernel, to match tanh approximation, as done on the generic platform

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. The CHANGELOG.md file has been updated.
  5. If the docker was modified, change back its link after review.

@diaconuccalin diaconuccalin self-assigned this Oct 16, 2025
@diaconuccalin diaconuccalin added Bug Something isn't working Feature Addition of new features labels Oct 16, 2025
@Xeratec Xeratec modified the milestones: Release 0.2.1, Release xxx Oct 23, 2025
@diaconuccalin @lukamac
Conv2D Bias Adaptation
c59f625
@diaconuccalin @lukamac
Adde PULPOpen support for Conv2D and partially working DW Conv2D. Fix…
8edf0c2 
…ed closure naming issue
@diaconuccalin @lukamac
DW 2D Float Conv for PULPOpen platform now working. Updated im2col bu…
b26d8ef 
…ffer size computation. Added fixes to remove warnings
@diaconuccalin @lukamac
Optimized the PULPOpen DW 2D fp32 Convolution and fixed the bias vers…
ec749d5 
…ion. Adjusted memory allocation for the im2col buffer in 2d float conv for PULPOpen (lower requirement, dynamic allocation). Included all Float 2D Conv tests in the CI pipeline for siracusa
@diaconuccalin @lukamac
Updated float reshape with skip connection test to a smaller one
b2ade51
@diaconuccalin @lukamac
Fixed generic platform alias_of bug
e58fa66
@diaconuccalin @lukamac
Fixed the PULPOpen FloatGemmTemplate (identical issue to the generic …
41cb270 
…version). Added MatMulAddMergePass to the PULP optimizer. Added float-reshape-skip-connection test to Siracusa CI pipeline. Fixes in the FloatAddTemplate of PULPOpen to eliminate warnings
@diaconuccalin @lukamac
Working TinyViT Demo test. Added it to the CI pipeline. Added float s…
6cbf247 
…lice and reduce mean bindings for Siracusa.
@diaconuccalin @lukamac
Added GEMM batched fix to MatMul template
afe1761
@diaconuccalin @lukamac
Fixed formatting
8ebe0aa
@diaconuccalin @lukamac
Fixes to avoid warnings
c413255
@diaconuccalin @lukamac
Fix formatting
f0e469c
@diaconuccalin @lukamac
Merge fix
a198973
@diaconuccalin @lukamac
Dynamic buffer calculation fix. Other fixes
545e5f4
@diaconuccalin @lukamac
Reformat
cadc0e8
@diaconuccalin @lukamac
Added back CI tests removed by merge
f12e117
@diaconuccalin @lukamac
Updated changelog file
35dd7ad
@diaconuccalin @lukamac
Applied fixes suggested in the PR review
db23d69
@diaconuccalin @lukamac
Post-merge fixes
adba733
@diaconuccalin @lukamac
Quickfix
884b8f2
@diaconuccalin @lukamac
PR fixes
7bcb512
@diaconuccalin @lukamac
Addressed PR review. Minor fix for aliasing in reshape parser
ebc02cf
@diaconuccalin @lukamac
Minor fix based on PR review
73dec31
@diaconuccalin @lukamac
Post-rebase fixes
a1aecff
@diaconuccalin
DW 2D Float Conv for PULPOpen platform now working. Updated im2col bu…
553f5ca 
…ffer size computation. Added fixes to remove warnings
@diaconuccalin
Optimized the PULPOpen DW 2D fp32 Convolution and fixed the bias vers…
b58a675 
…ion. Adjusted memory allocation for the im2col buffer in 2d float conv for PULPOpen (lower requirement, dynamic allocation). Included all Float 2D Conv tests in the CI pipeline for siracusa
@diaconuccalin
Fixed generic platform alias_of bug
12b5f43
@diaconuccalin
Fixed the PULPOpen FloatGemmTemplate (identical issue to the generic …
787b37f 
…version). Added MatMulAddMergePass to the PULP optimizer. Added float-reshape-skip-connection test to Siracusa CI pipeline. Fixes in the FloatAddTemplate of PULPOpen to eliminate warnings
@diaconuccalin
Fixed formatting
6d340e8
@diaconuccalin
Fixes to avoid warnings
765683a
@diaconuccalin
Merge fix
e40123f
@diaconuccalin
Dynamic buffer calculation fix. Other fixes
576d3ac
@diaconuccalin
Added back CI tests removed by merge
c9818a2
@diaconuccalin
Applied fixes suggested in the PR review
25f8041
@diaconuccalin
Post-merge fixes
18c372b
@diaconuccalin
Included bias handling in tile constraint handling for conv 2D. Fix i…
c477fa8 
…n input cube size computation for conv 2D constraint. Other fixes to remove warnings
@diaconuccalin
Fixed input cube computation for 2D conv tiling
09b64ea
@diaconuccalin
Added tiling bias handling for regular Conv2D in PULPOpen
c268d70
@diaconuccalin
Added core number information to the network container, for buffer al…
a03e54c 
…location in im2col
@diaconuccalin
Added non-RQ FP DW Conv2D tiling-ready binding and constraints. Test …
b22786b 
…runner fix. Format fixes
@diaconuccalin
Bias support for DW 2d Conv tiling. im2col buffer computation fix. co…
b5bc35c 
…mputeInputCube() backwards compatiblity fix
@diaconuccalin
Added broadcasting handling for MatMul tile constraint. Fixed formatting
41ba8b9
@diaconuccalin
Added prototypes for PULPOpen Slice and ReduceMean tiling constraints
67c7354
@diaconuccalin
Added geometrical constraint and serialization for the slice operation
320cf08
@diaconuccalin
Added geometrical constraints and tiling serialization to the ReduceM…
312bdbf 
…ean operator. Slice constraints fix. Other fixes
@diaconuccalin
Updated PULP GELU function to generic version (while keeping the para…
115473c 
…llelization)
@diaconuccalin
Fix core number value passing. Minor PULP GELU clean up
cbfdc26
@diaconuccalin
Fixed PULP DW 2D Conv geometrical tile constraints
c3f3a2c
@diaconuccalin
Fixes in DWConv2D and MatMul tile constraints
9ce4eb3
@diaconuccalin
Fixed formatting
7a1e329
@diaconuccalin
MatMul constraint fix
d7bf145
@diaconuccalin
Fixed unique item check
41493eb
@diaconuccalin
Format fix
95d30e5
@diaconuccalin diaconuccalin force-pushed the DemoTinyViT_Tiled_Siracusa branch from 0f8c014 to 95d30e5 Compare November 3, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Victor-Jung Victor-Jung Awaiting requested review from Victor-Jung Victor-Jung will be requested when the pull request is marked ready for review Victor-Jung is a code owner

@Xeratec Xeratec Awaiting requested review from Xeratec Xeratec will be requested when the pull request is marked ready for review Xeratec is a code owner

@lukamac lukamac Awaiting requested review from lukamac lukamac will be requested when the pull request is marked ready for review lukamac is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@diaconuccalin diaconuccalin

Labels

Bug Something isn't working Feature Addition of new features

Projects

Deeploy
Status: No status

Milestone

Release xxx

Development

Successfully merging this pull request may close these issues.

3 participants

@diaconuccalin @Xeratec @lukamac