Ch6 - generalize concrete test Action Multiply (Array Int) #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomain
changed the title
milesfrain
reviewed
May 13, 2021
exercises/chapter6/test/Main.purs
Outdated
| @@ -208,7 +208,7 @@ Note to reader: Delete this line to expand comment block -} | |||
| Assert.equal (act m1 (act m2 a)) | |||
| $ act (m1 <> m2) a | |||
| test "Multiply Array Int concrete" do | |||
There was a problem hiding this comment.
Don't know if "concrete" is still the best name here, but can't think of anything better at the moment.
There was a problem hiding this comment.
How about "Acts on array elements"?
There was a problem hiding this comment.
This changes the schema of test-naming though. Maybe do as part of #138.
There was a problem hiding this comment.
How about "Acts on array elements"?
Sounds good to me
gomain
force-pushed
the
generalize-concrete-test-action-multiply-array
branch
from
72428fe to
a108c5f
Compare
|
Superseded by #338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #334, the current test relies on a specific implementation of
Action Multiply Int.