- 
                Notifications
    
You must be signed in to change notification settings  - Fork 10
 
Don't highlight top-level-only keywords at different levels #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't highlight top-level-only keywords at different levels #24
Conversation
719d4e2    to
    ab85b8d      
    Compare
  
    | 
           upd: added   | 
    
The keywords being modified here only represented keywords when they
are at the beginning of a line with optional indentation.
At different levels these would represent valid record fields or other
identifiers.
This was tested by adding the following code to a PureScript file:
    type Foo = { type :: Int
               , module :: Int
               , import :: Int
               , data :: Int
               , class :: Int
               , newtype :: Int
               }
…and checking that compilation succeeds.
    ab85b8d    to
    ba3e997      
    Compare
  
    | 
           @kritzcreek , ping?  | 
    
| 
           ping  | 
    
    
      
        1 similar comment
      
    
  
    | 
           ping  | 
    
PureScript, as opposed to Haskell, doesn't seem to have `deriving` as a keyword. I grepped over `purescript` compiler `tests/` directory to be sure. Instead it has `derive` keyword, which is a top level one that serves similar purpose to "deriving". So rename `deriving` to `derive`.
| 
           New commit:  | 
    
| 
           @purcell hello, it seems this repository became unmaintained. It has lots of PRs at this point, one of them even fixes a regression, but there's no one to review and merge the code. The amount of PRs became so large at this point that some changes even conflict with each other, and the last commit I had to add to this PR instead of making it a separate one. Do you mind giving me maintainer permissions? I am currently using PureScript, so I'm interested in making sure it works. I won't promise to fix issues though (unless they're regressions, of course), but I do fix from time to time some things that I stumble upon during the mode usage. I am a co-maintainer to color-identifiers-mode.  | 
    
| 
           Okay, first of all I'm merging this, thanks, and taking a quick look at other PRs to get a sense of things.  | 
    
| 
           Thank you!  | 
    
The keywords being modified here only represented keywords when they are at the beginning of a line with optional whitespace.
At different levels these would represent valid record fields or other identifiers.
This was tested by adding the following code to a PureScript file:
…and checking that compilation succeeds.