Skip to content

Conversation

@corlard3y
Copy link
Collaborator

Pull Request Template

#2037

Description

  • Problem/Feature:
  • Fix Channel Subscription on inner channels page

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

In the ChannelDetails.tsx file:

  1. In the useEffect hook, a typo in changing 'fetchNextPage' to 'fetchNextPage()'. It should be fixed as follows:
    const { data, fetchNextPage, hasNextPage, isLoading, isFetchingNextPage } = useGetChannelslist({
      pageSize: 15,
    });
  2. In the ChannelDetails.tsx file, there are missing closing braces for ChannelDetails component and missing import statements. Both should be added at the end of the file.
  3. In the ChannelDetails.tsx file, the comment {/* Render Unlock profile modal if the profile is not enabled */} should be closed properly as </>.
  4. The ChannelDetail component is missing proper closing tags for JSX elements.

In the ChannelDetail.tsx file:

  1. There are missing closing tags for JSX elements in the ChannelDetail component. Each JSX element should be properly closed.
  2. There is a typo in the import statement import { ChannelDetails } from 'queries';, should be import { ChannelDetails } from '../../queries';.

In the ChannelDetailSubscribe.tsx file:

  1. In the ChannelDetailSubscribe component, there is a missing closing brace for the element.

In the ChannelList.tsx file:

  1. In the ChannelList component, there is a missing closing tag for the element.

All other code appears to be correct.

Overall, some syntax errors, typos, and missing closing tags need to be corrected.

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

All looks good.

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2025-06-17 19:14 UTC

@riyanshu-patro riyanshu-patro merged commit 648b515 into main Jun 17, 2025
2 checks passed
@riyanshu-patro riyanshu-patro deleted the fixChannelsBug branch June 17, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants