Skip to content

Conversation

@corlard3y
Copy link
Collaborator

@corlard3y corlard3y commented Dec 25, 2025

Pull Request Template

Ticket Number

Description

Update stats in push points

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@github-actions
Copy link

In the file src/modules/pointsVault/components/PointsVaultApprovedList.tsx:

  1. In the useEffect hook, the dependency array is missing a closing bracket ']' at the end. It should be:
  useEffect(() => {
    setCurrentPage(1);
  }, [query.twitter, query.wallet]);
  1. In the handleRefetch function, the return statement is missing a closing bracket '}' at end of the function. It should be:
const handleRefetch = () => {
    refetch();
    queryClient.invalidateQueries({ queryKey: [pointsVaultRejectedUsers] });
  };
  1. There is a missing closing tag for the return statement. It should have a closing '' tag at the end.

  2. There is a missing closing tag for the handlePageChange function. It should have a closing '}' at the end of the function.

  3. In the handlePageChange function, setCurrentPage should be called with the 'page' parameter. It should be:

  const handlePageChange = (page: number) => {
    setCurrentPage(page);
  };

After addressing these issues, the code in src/modules/pointsVault/components/PointsVaultApprovedList.tsx looks good.

In the other files, PointsVaultListColumns.tsx, PointsVaultListContainer.tsx, and PointsVaultListItem.tsx, no issues were found.

All looks good.

@github-actions
Copy link

github-actions bot commented Dec 25, 2025

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2025-12-25 12:58 UTC

@riyanshu-patro riyanshu-patro self-requested a review December 25, 2025 12:50
@HarshRajat HarshRajat merged commit ad939ac into main Dec 25, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants