Skip to content

Conversation

@pvktk
Copy link
Owner

@pvktk pvktk commented Sep 24, 2018

No description provided.

Copy link

@sproshev sproshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

зачтено с замечанием по reset

private RepInformation inform = null;
private Path informPath = null;
private final String infoFileName = ".myGitData";
private final String storageFolder = ".mygitdata";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в винде эти два имени неразличимы

//Files.copy(orig, dest);
FileUtils.copyFile(orig.toFile(), dest.toFile());
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

по названиям не понять, что addFile и makeAdd довольно разные


private void addFile(Path filepath) throws IOException {
int revision = inform.revision;
Path keyPath = filepath.subpath(1, filepath.getNameCount());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

почему первый элемент откусывается?

inform.revision = revision;
inform.commitMessages.subList(revision , inform.commitMessages.size()).clear();
inform.timestamps.subList(revision, inform.timestamps.size()).clear();
updateRepInformation();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage не чистится

return "revision: " + revision + "\n"
+ inform.commitMessages.get(revision - 1) + "\n"
+ inform.timestamps.get(revision - 1);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

по логгингу замечание было, это я помню)


@Override
public FileVisitResult postVisitDirectory(Path dir, IOException exc) throws IOException {
// TODO Auto-generated method stub

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

эти комментарии надо удалять, иначе код выглядит недописанным

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants