-
Notifications
You must be signed in to change notification settings - Fork 0
Java06. ДЗ 02, Егоров Антон #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
sproshev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
зачтено с замечанием по reset
| private RepInformation inform = null; | ||
| private Path informPath = null; | ||
| private final String infoFileName = ".myGitData"; | ||
| private final String storageFolder = ".mygitdata"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в винде эти два имени неразличимы
| //Files.copy(orig, dest); | ||
| FileUtils.copyFile(orig.toFile(), dest.toFile()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
по названиям не понять, что addFile и makeAdd довольно разные
|
|
||
| private void addFile(Path filepath) throws IOException { | ||
| int revision = inform.revision; | ||
| Path keyPath = filepath.subpath(1, filepath.getNameCount()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
почему первый элемент откусывается?
| inform.revision = revision; | ||
| inform.commitMessages.subList(revision , inform.commitMessages.size()).clear(); | ||
| inform.timestamps.subList(revision, inform.timestamps.size()).clear(); | ||
| updateRepInformation(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storage не чистится
| return "revision: " + revision + "\n" | ||
| + inform.commitMessages.get(revision - 1) + "\n" | ||
| + inform.timestamps.get(revision - 1); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
по логгингу замечание было, это я помню)
|
|
||
| @Override | ||
| public FileVisitResult postVisitDirectory(Path dir, IOException exc) throws IOException { | ||
| // TODO Auto-generated method stub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
эти комментарии надо удалять, иначе код выглядит недописанным
No description provided.