-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Batzelis 2017 simple nonlinear PV model #2563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR currently adds three new functions. As they are related to each other I thought it would be helpful to review them together, but I can split the PR into smaller pieces to make it more digestible if needed. To summarize the three functions:
The third, effectively, combines the first two with Questions for reviewers:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some reactions.
This method is described in Section II.C of [1]_. | ||
Parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer alpha_sc
and beta_voc
to be required in units of A/K and V/K, respectively. The parameters alpha_sc
and beta_voc
in sdm.fit_desoto, sdm.fit_cec_sam and other function (notably, pvsystem.calcparams_desoto) use those units.
Do we want the STC parameters to have the same names as in pvsystem.sapm? I'm not a fan of the SAPM names, which derive from some old spreadsheet's column headings. But they are the same quantities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
units of A/K and V/K
done
Do we want the STC parameters to have the same names as in pvsystem.sapm? I'm not a fan of the SAPM names,
Me neither. fit_desoto
uses just the usual v_mp
etc. This PR now uses v_mp
etc. too, although those are obviously not ideal either.
A question about the method: does |
Close but not exactly the same, in my testing. The latter has to be |
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.