Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update did error handling of time variables #756

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+1,644 −1,487
Open

update did error handling of time variables #756

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a08e8
update did error handling of time variables
s3alfisc Dec 19, 2024
e35f315
cleanup
s3alfisc Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
cleanup
@s3alfisc
s3alfisc committed Dec 19, 2024
commit e35f315e82f6afc341ca09edd34100ee66f851f3
2 changes: 0 additions & 2 deletions pyfixest/did/did.py
View file
Original file line number Diff line number Diff line change
@@ -81,12 +81,10 @@ def __init__(
"""
)

# import pdb; pdb.set_trace()
# check if gname is included in tname values
self._tname_unique = self._data[self._tname].unique()
self._gname_unique = self._data[self._gname].unique()

# import pdb; pdb.set_trace()
if np.isin(0, self._tname_unique).any():
raise ValueError(
f"""The value 0 was found in the 'tname' variable {self._tname}.