Skip to content

feat: support iconify icon keys #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 31, 2023

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Oct 27, 2023

This PR

see #132 for follow up with color stuff

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80c795e) 99.54% compared to head (43b8ddb) 99.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          31       31           
  Lines        1746     1748    +2     
=======================================
+ Hits         1738     1740    +2     
  Misses          8        8           
Files Coverage Δ
src/app_model/backends/qt/_qaction.py 100.00% <100.00%> (ø)
src/app_model/backends/qt/_util.py 100.00% <100.00%> (ø)
src/app_model/types/_command_rule.py 100.00% <ø> (ø)
src/app_model/types/_icon.py 100.00% <ø> (ø)
src/app_model/types/_menu_rule.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 requested a review from Czaki October 28, 2023 13:41
@tlambert03
Copy link
Member Author

cc @jni, @Czaki ... nothing here affects napari, since napari still doesn't use app-model for it's icons. But plugins could conceivable in the future if anyone starts using the commands.icon spec ... this makes it easier for them to pick icons from iconify

@tlambert03 tlambert03 changed the title feat: support iconify icon keys, and better control of icon colors [wip] feat: support iconify icon keys, and better control of icon colors Oct 30, 2023
@tlambert03 tlambert03 changed the title feat: support iconify icon keys, and better control of icon colors feat: support iconify icon keys Oct 31, 2023
@tlambert03
Copy link
Member Author

I pulled off the color spec into #132 ... not entirely sure about that part yet. so this is just iconify now

@tlambert03 tlambert03 enabled auto-merge (squash) October 31, 2023 20:07
@tlambert03 tlambert03 merged commit e964e21 into pyapp-kit:main Oct 31, 2023
@tlambert03 tlambert03 deleted the icon-color-iconify branch October 31, 2023 20:16
@tlambert03 tlambert03 added the enhancement New feature or request label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

1 participant