-
Notifications
You must be signed in to change notification settings - Fork 15
feat: support iconify icon keys #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 31 31
Lines 1746 1748 +2
=======================================
+ Hits 1738 1740 +2
Misses 8 8
☔ View full report in Codecov by Sentry. |
cc @jni, @Czaki ... nothing here affects napari, since napari still doesn't use app-model for it's icons. But plugins could conceivable in the future if anyone starts using the |
I pulled off the color spec into #132 ... not entirely sure about that part yet. so this is just iconify now |
…p-model into icon-color-iconify
This PR
see #132 for follow up with color stuff