WIP: feat: Add autoscale tails to Jupyter #179
+163
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the python side cannot receive updates from the frontend - probably being bitten by trying to take shortcuts here, and should read through the docs on how to do this correctly (see https://ipywidgets.readthedocs.io/en/stable/examples/Widget%20Low%20Level.html)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 85.11% 85.36% +0.24%
==========================================
Files 45 45
Lines 4783 4809 +26
==========================================
+ Hits 4071 4105 +34
+ Misses 712 704 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@tlambert03 I think this is working well now - do you have time to take another look? Unfortunately, when you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs cleanup I think, also seems broken⚠️