Skip to content

feat: remove array data display #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gselzer
Copy link
Collaborator

@gselzer gselzer commented Apr 25, 2025

This PR removes _ArrayDataDisplayModel, in favor of storing all contained behavior within the DataWrapper and the ArrayDisplayModel. More particularly, the ArrayDisplayModel is now in charge of slicing the wrapper.

There may be other ways to get rid of the _ArrayDataDisplayModel that have merit, and I'm not opposed to experimentation.

gselzer added 3 commits April 25, 2025 16:11
The next commit will be amazing
Wasn't that amazing?
...well, the previous commit could have been more amazing...
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 26 lines in your changes missing coverage. Please review.

Project coverage is 85.19%. Comparing base (87a10a9) to head (f6ccfa7).

Files with missing lines Patch % Lines
src/ndv/controllers/_array_viewer.py 70.58% 15 Missing ⚠️
src/ndv/models/_array_display_model.py 85.71% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   85.11%   85.19%   +0.07%     
==========================================
  Files          45       44       -1     
  Lines        4783     4754      -29     
==========================================
- Hits         4071     4050      -21     
+ Misses        712      704       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant