Skip to content

refactor: lots of typing updates, add pyright tests on CI #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tlambert03
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 68.50394% with 40 lines in your changes missing coverage. Please review.

Project coverage is 82.88%. Comparing base (87a10a9) to head (95c5adb).

Files with missing lines Patch % Lines
src/ndv/views/_pygfx/_array_canvas.py 31.81% 15 Missing ⚠️
src/ndv/views/_wx/_array_view.py 78.26% 5 Missing ⚠️
src/ndv/views/_wx/range_slider.py 73.68% 5 Missing ⚠️
src/ndv/views/bases/_app.py 42.85% 4 Missing ⚠️
src/ndv/models/_lut_model.py 0.00% 2 Missing ⚠️
src/ndv/views/_pygfx/_util.py 50.00% 2 Missing ⚠️
src/ndv/views/_vispy/_array_canvas.py 85.71% 2 Missing ⚠️
src/ndv/views/_vispy/_histogram.py 83.33% 2 Missing ⚠️
src/ndv/views/_pygfx/_histogram.py 0.00% 1 Missing ⚠️
src/ndv/views/_qt/_array_view.py 93.33% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   85.11%   82.88%   -2.23%     
==========================================
  Files          45       45              
  Lines        4783     4797      +14     
==========================================
- Hits         4071     3976      -95     
- Misses        712      821     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant