feat: model-based zoom_to_fit #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines how 2D view NDC are mapped to vectors in 3D space
In the pursuit of a single source of truth, let's resort to the projection matrix (when/if possible?) for this.
For some reason, if I don't do this, the Matrix3D constructor RESURRECTS some previous matrix I used in a previous test
Thanks to @tlambert03 for the suggestion. Could probably be cleaned up further, but at least this is a step in the right direction!
Eventually, we'll want to compute grids ourselves on the model side, I think, but for now this works
...man, this feels so good
It's worse :)
Notably, this limits the type of pygfx-specific interaction available. But we need a scenex version of this anyways - planning to implement the beginnings of this with events
Still need to add that functionality to child nodes...somehow :)
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 80.83% 82.48% +1.64%
==========================================
Files 42 43 +1
Lines 1529 1593 +64
==========================================
+ Hits 1236 1314 +78
+ Misses 293 279 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
very exciting! Away for work this week, but will try to sneak in a review at some point soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements "zoom to fit" functionality as computations on the scenegraph model, replacing the existing implementations which delegated the functionality to the current visualization toolkit.
Builds atop #27.