wip: feat: lines #33
Draft
wip: feat: lines #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines how 2D view NDC are mapped to vectors in 3D space
In the pursuit of a single source of truth, let's resort to the projection matrix (when/if possible?) for this.
For some reason, if I don't do this, the Matrix3D constructor RESURRECTS some previous matrix I used in a previous test
Thanks to @tlambert03 for the suggestion. Could probably be cleaned up further, but at least this is a step in the right direction!
Eventually, we'll want to compute grids ourselves on the model side, I think, but for now this works
...man, this feels so good
It's worse :)
Notably, this limits the type of pygfx-specific interaction available. But we need a scenex version of this anyways - planning to implement the beginnings of this with events
Still need to add that functionality to child nodes...somehow :)
The main thing to avoid here is a View layout larger than a canvas, as that can cause problems in Pygfx
Some airport fixes coming around from me using my laptop screen for once :)
Let's just keep wx out of the CI linting...
I just want the tests passing man
Currently being hit by not having this with wxPython
This is a clean solution for implementing "on-leave" behavior. In NDV's case, it's needed to clear the hover info when the cursor leaves the image.
scenex image/volume nodes have pixel centers at integer coordinates. Our math needs to reflect that
Tried my best to explain via comments why I think it's the right choice
Also needed for ndv :)
Vectorized, Documented
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 80.72% 84.48% +3.76%
==========================================
Files 42 54 +12
Lines 1520 2495 +975
==========================================
+ Hits 1227 2108 +881
- Misses 293 387 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another addendum to #28 - this time adding support for lines. The GIF below shows a simple example I cooked up where clicking and dragging the sinusoid adjusts the phase to remain under the user's cursor.
Lines are trickier than theMeshes added in #32 or the existing images/volumes because their appearance (namely their width) is defined in pixel space, not in world space (there's actually a similarity here to thePointsnode, which are at this point improperly handled, and would also be nice for aTextnode, which I may want to implement soon). This means that we have to compute the intersection in canvas space.This PR enables that by giving the
Rayobject access to theViewcapturing the user's event. I'm open to alternative designs here for sure.I think that a follow-up PR would be good for adjusting the
Points class to similarly perform its intersection checks in canvas space. We could even consider checking all intersections in canvas space, although I'd rather not redo that work 😅.