Skip to content

ci: add nightlies for scientific-python #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented May 20, 2025

Description

See scientific-python/upload-nightly-action#134

Also fixes an issue with the PyPI job building wheels.

Suggested changelog entry:

  • Add nightly wheels to scientific-python's nightly wheelhouse

@henryiii henryiii requested a review from Copilot May 20, 2025 06:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces changes in the CI workflows to switch from using uv’s internal build commands to nox-based builds, and it adds a new workflow for uploading nightly wheels.

  • Modify the pip workflow to install additional dependencies and update build commands.
  • Add a new nightlies workflow that builds wheels and uploads them to Anaconda Cloud.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/pip.yml Updated environment preparation, build commands, and artifact globbing pattern.
.github/workflows/nightlies.yml Added a new workflow for building and uploading nightly wheels.
Comments suppressed due to low confidence (3)

.github/workflows/nightlies.yml:20

  • The condition 'github.repository_owner == "pybind"' may be misconfigured since the PR targets scientific-python. Please verify and update it to match the intended repository owner.
if: github.repository_owner == 'pybind'

.github/workflows/nightlies.yml:43

  • The upload job also checks for 'pybind' as the repository owner, which might prevent running in scientific-python. Confirm and adjust the condition as needed.
if: github.repository_owner == 'pybind'

.github/workflows/pip.yml:84

  • [nitpick] The glob pattern 'global-' is broader than the previous 'pybind11_global-*'; please verify that it only captures the intended artifacts.
path: dist/*global-*

@henryiii henryiii merged commit 3867c5f into pybind:master May 20, 2025
73 checks passed
@henryiii henryiii deleted the henryiii/ci/nightliesanaconda branch May 20, 2025 14:42
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Possibly needs a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant