WIP: add ble connect timeout #1430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - https://crbug.com/1406311 needs to be fixed - timeout needs to be added to bootloader connect as well Issue: pybricks/support#911
Codecov ReportBase: 69.33% // Head: 69.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1430 +/- ##
==========================================
- Coverage 69.33% 69.27% -0.06%
==========================================
Files 194 195 +1
Lines 4878 4899 +21
Branches 1010 1012 +2
==========================================
+ Hits 3382 3394 +12
- Misses 1469 1478 +9
Partials 27 27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This should be unblocked by https://chromium-review.googlesource.com/c/chromium/src/+/6798921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Issue: pybricks/support#911