Release the GIL during core EC and RSA cryptographic operations - #14370
Merged
Merged
Conversation
Wrap CPU-intensive OpenSSL calls in py.detach() to release the GIL, allowing other Python threads to run during cryptographic operations. Operations covered: - EC key generation, ECDH key exchange, ECDSA sign/verify - RSA key generation, sign/verify, encrypt/decrypt https://claude.ai/code/session_01TbN4mmRwmt1boDWU8Gwb5E
reaperhulk
reviewed
Feb 24, 2026
| let ossl_curve = curve_from_py_curve(py, curve)?; | ||
| let key = openssl::ec::EcKey::generate(&ossl_curve)?; | ||
| let pkey = py.detach(|| { | ||
| let key = openssl::ec::EcKey::generate(&ossl_curve)?; |
Member
There was a problem hiding this comment.
I suspect this isn't worth doing, EC key generation is fast
EC key generation is fast enough that releasing the GIL adds unnecessary overhead. https://claude.ai/code/session_01TbN4mmRwmt1boDWU8Gwb5E
reaperhulk
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap CPU-intensive OpenSSL calls in py.detach() to release the GIL, allowing other Python threads to run during cryptographic operations.
Operations covered:
https://claude.ai/code/session_01TbN4mmRwmt1boDWU8Gwb5E