Build abi3.abi3t wheels for CPython 3.15+ - #15496
Conversation
alex
left a comment
There was a problem hiding this comment.
@reaperhulk do we want to drop 3.14t wheels as soon as we're doing abi3t wheels? I strongly prefer that, but curious for your views.
| with: | ||
| python-version: ${{ inputs.python-version }} | ||
| architecture: ${{ inputs.arch }} | ||
| allow-prereleases: ${{ inputs.python-version == '3.15t' }} |
There was a problem hiding this comment.
We do not want to ever use allow-prereleases. If you want to use a pre-release, you should specify the version.
There was a problem hiding this comment.
I removed the usage of allow-prereleases.
Depending on the decision by maintainers regarding when this should be available, the modifications could be reduced for Windows if after 3.15.0.final (they can always be reverted after 3.15.0.final if this goes in before that)
Normally I’d be strongly against that, but I think free-threaded consumers are pretty aggressive in their upgrades right now. However, if we’re shipping abi3t day 1 of 3.15 we’re cutting off wheels for every existing free-threaded consumer so I think we need one release with both? |
|
Well, we'd need to choose when we want to do a release with this. Are we gonig to try to have it for 3.15 release day? |
|
Ok, we've discussed and we'd like to land this in the next month and then we'll backport it and do a point release. Can you fix the merge conflicts? THanks! |
| PYTHON: {VERSION: "3.15-dev", "ABI_VERSION": "py311"} | ||
| PYTHON: {VERSION: "3.15.0-rc.2", "ABI_VERSION": "abi3t-py315", FREETHREADED: true} |
|
Just some notes:
|
|
Thanks! I just kicked off a rebuild of our docker images, so rc2 should be available momentarily. |
|
Linux is now getting 3.15.0rc2 after the rebuild of docker images |
| - {VERSION: "3.14t", FREETHREADED: true} | ||
| - {VERSION: "3.15.0-rc.2", "ABI_VERSION": "abi3t-py315", FREETHREADED: true} |
There was a problem hiding this comment.
hmm, why do these need the FREETHREADED: true, is the t in the version not sufficient?
There was a problem hiding this comment.
It's only for consistency when t is in the version spec but the 3.15.0-rc.2 version can't have t in its spec (setup-python limitation) which is why FREETHREADED was a needed addition in the first place.
Relates to #15496 (comment) (although the comment was not explicit about which modification was added for rc vs final, this is the one).
alex
left a comment
There was a problem hiding this comment.
Besides that question, this lgtm
This is a follow-up on #15063 which updates the wheel-builder workflow to build abi3.abi3t wheels for CPython 3.15+ now that CPython 3.15.0rc1 is available.
From #15063:
Release automation uses the wheel-builder workflow updated here.
Python 3.15 has been added in project classifiers.