Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
@marcelm I noticed Sequali was bottlenecked by the gzip decompression. On the latest develop branch, analysing ONT files is faster than decompressing them. On BAM formats however this can be theoretically circumvented beacuse all BGZIP blocks are independent. FASTQ files are also often bgzip compressed. So I set out to write some code to alleviate this.
It works. Question is how to integrate this properly into xopen. My thoughts on this are
isal.bgzip
).isal.igzip_threaded
as there is less overhead involved.xopen
detect the bgzip format by parsing the gzip header and use bgzip.open if that is the case.What are your thoughts on this?