Skip to content

Expose max_retry_delay via client #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentijnscholten wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose max_retry_delay via client #2400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions jira/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ def __init__(
async_workers: int = 5,
logging: bool = True,
max_retries: int = 3,
max_retry_delay: int = 60,
proxies: Any | None = None,
timeout: None | float | tuple[float, float] | tuple[float, None] | None = None,
auth: tuple[str, str] | None = None,
Expand Down Expand Up @@ -549,6 +550,7 @@ def __init__(
timeout (Optional[Union[Union[float, int], Tuple[float, float]]]): Set a connect/read timeout for the underlying calls to Jira.
Obviously this means that you cannot rely on the return code when this is enabled.
max_retries (int): Sets the amount Retries for the HTTP sessions initiated by the client. (Default: ``3``)
max_retry_delay (int): Sets the maximum delay in seconds allowed between retries. (Default: ``60``)
proxies (Optional[Any]): Sets the proxies for the HTTP session.
auth (Optional[Tuple[str,str]]): Set a cookie auth token if this is required.
logging (bool): True enables loglevel to info => else critical. (Default: ``True``)
Expand Down Expand Up @@ -611,7 +613,9 @@ def __init__(
assert isinstance(self._options["headers"], dict) # for mypy benefit

# Create Session object and update with config options first
self._session = ResilientSession(timeout=timeout)
self._session = ResilientSession(
timeout=timeout, max_retries=max_retries, max_retry_delay=max_retry_delay
)
# Add the client authentication certificate to the request if configured
self._add_client_cert_to_session()
# Add the SSL Cert to the request if configured
Expand All @@ -622,8 +626,6 @@ def __init__(
if "cookies" in self._options:
self._session.cookies.update(self._options["cookies"])

self._session.max_retries = max_retries

if proxies:
self._session.proxies = proxies

Expand Down
Loading