Skip to content

Add HTTP/2 large-body send benchmark and CodSpeed memory mode - #1128

Merged
Kludex merged 3 commits into
mainfrom
http2-memory-benchmark
Aug 9, 2026
Merged

Add HTTP/2 large-body send benchmark and CodSpeed memory mode#1128
Kludex merged 3 commits into
mainfrom
http2-memory-benchmark

Conversation

@Kludex

@Kludex Kludex commented Aug 9, 2026

Copy link
Copy Markdown
Member

Adds a benchmark exercising the HTTP/2 request-body send path (HTTP2Connection sending an 8 MiB bytes body over a MockStream with a large flow window), and a second CodSpeed job running the suite in memory mode.

This establishes a baseline so the CPU and allocation improvements in #1127 show up on CodSpeed - the send path on main currently does quadratic tail copying (#1039).

AI Disclaimer

This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.

Review in cubic

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

@codspeed-hq

codspeed-hq Bot commented Aug 9, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 16 untouched benchmarks
🆕 1 new benchmark
⏩ 7 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 Memory test_bench_http2_send_large_body N/A 16 MB N/A

Comparing http2-memory-benchmark (729b5ab) with main (dec24ad)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ab986f31a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mode: instrumentation
run: uv run pytest tests/test_benchmark.py --codspeed

memory-benchmarks:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Attribute the commit solely to the engineer

This commit records Codex <codex@openai.com> as both author and committer, so the coding agent owns the authorship instead of the engineer. Recreate the commit with the engineer as the sole author before merging, as required by the repository instructions.

AGENTS.md reference: AGENTS.md:L3-L3

Useful? React with 👍 / 👎.

@Kludex
Kludex enabled auto-merge (squash) August 9, 2026 08:20
@Kludex
Kludex merged commit d6d7ec3 into main Aug 9, 2026
19 checks passed
@Kludex
Kludex deleted the http2-memory-benchmark branch August 9, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant