Add HTTP/2 large-body send benchmark and CodSpeed memory mode - #1128
Conversation
|
Docs preview: https://4058bca7-httpx2-docs.pydantic.workers.dev |
Merging this PR will not alter performance
Performance Changes
Comparing Footnotes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ab986f31a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mode: instrumentation | ||
| run: uv run pytest tests/test_benchmark.py --codspeed | ||
|
|
||
| memory-benchmarks: |
There was a problem hiding this comment.
Attribute the commit solely to the engineer
This commit records Codex <codex@openai.com> as both author and committer, so the coding agent owns the authorship instead of the engineer. Recreate the commit with the engineer as the sole author before merging, as required by the repository instructions.
AGENTS.md reference: AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
Adds a benchmark exercising the HTTP/2 request-body send path (
HTTP2Connectionsending an 8 MiBbytesbody over aMockStreamwith a large flow window), and a second CodSpeed job running the suite inmemorymode.This establishes a baseline so the CPU and allocation improvements in #1127 show up on CodSpeed - the send path on
maincurrently does quadratic tail copying (#1039).AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.