indexing with a list of slices #10573
Open
+239
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #10479, this adds support for a list-of-slices container (tentatively called
MultipleSlices
) to most of the indexing wrapper classes. Still missing:PandasIndexingWrapper
.It didn't look like using a separate class as suggested in #10479 (comment) would be easy, and so I've decided to instead extend
_index_indexer_1d
to support, which turned out surprisingly easy.I'll still have to figure out how to best test this for the indexing wrapper classes other than
LazilyIndexingWrapper
, and I'm not really content with the API and the code duplication I have right now. I'll refactor that soon, but for now this works:cc @dcherian
whats-new.rst
api.rst