Skip to content

Fix freeze when reading corrupt XLSX files #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Fix freeze when reading corrupt XLSX files #12

wants to merge 4 commits into from

Conversation

PLPeeters
Copy link

I had a case where a corrupt XLSX file caused pyexcel to hang forever when reading with iget_records.

This PR contains:

  • A fix for the above
  • General improvements to the regular expressions
  • A migration of the tests to pytest

Ironically, my corrupt XLSX file is read perfectly fine after the changes.

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@PLPeeters
Copy link
Author

@chfw Any chance you could take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PLPeeters