This repository was archived by the owner on Aug 15, 2021. It is now read-only.
Fixups for conversions #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmccallum
commented
Jul 5, 2020
npmccallum
commented
- Add tests to ensure From conversions and serializations are consistent.
- Fix the inconsistencies.
- New conversions for increased ergonomics.
Serde uses a blanket impl for serialization. This change fixes the From conversions to match serde's behavior. Without this, the user of serde_cbor could run into awkward bugs where values of the same type get serialized different ways; all hidden behind an innocent looking .into().
It made sense to avoid these in the past because they caused allocation. However, in order to fix conversion mismatches with serde, we had to adopt allocation. Since we have now accepted allocation, it now makes sense to add these conversions for ergonomics.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.