Fix: Prevent DDP Crash by Enabling find_unused_parameters=True in GITMol Training #10304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a DDP runtime error triggered on some machines during multi-GPU training of the GITMol model, caused by conditionally unused parameters in the model's forward pass.
🧠 Root Cause
The following call:
internally uses
DistributedDataParallel(find_unused_parameters=False)
by default. This means:The GITMol model is a multi-modal architecture that processes molecular graphs, SMILES strings, images, and captions. Due to this design, not all model parameters are guaranteed to participate in the forward pass for every batch (e.g., if an input modality is missing or conditionally ignored). This causes DDP to crash unless configured to tolerate such behavior.
📈 Impact
🧪 Tested On
GB200 & B200 nodes across multiple runs.
Training runs no longer crash under multi-GPU execution.