Skip to content

Commit

Permalink
Simplify er_blade
Browse files Browse the repository at this point in the history
This function did two things unnecessarily:

* Convert blade reps to base rep before calling mul. This is already handled within `mul`, so there's no need to do it again at the call site.
* Branch depending on the mode string - this branching is already handled by `Mul`
  • Loading branch information
eric-wieser committed Dec 18, 2019
1 parent d4fe3db commit 16de7db
Showing 1 changed file with 3 additions and 15 deletions.
18 changes: 3 additions & 15 deletions galgebra/ga.py
Original file line number Diff line number Diff line change
Expand Up @@ -1650,22 +1650,10 @@ def er_blade(self, er, blade, mode='*', left=True):
.. math:: e^{j}*(e_{i_{1}}\wedge ...\wedge e_{i_{r}})
"""
if mode == '*':
base = self.blade_to_base_rep(blade)
if left:
return self.base_to_blade_rep(self.mul(er, base))
else:
return self.base_to_blade_rep(self.mul(base, er))
elif mode == '^':
if left:
return self.wedge(er, blade)
else:
return self.wedge(blade, er)
if left:
return self.Mul(er, blade, mode=mode)
else:
if left:
return self.Mul(er, blade, mode=mode)
else:
return self.Mul(blade, er, mode=mode)
return self.Mul(blade, er, mode=mode)

def blade_derivation(self, blade, ib):
"""
Expand Down

0 comments on commit 16de7db

Please sign in to comment.