Add example that shows dragging #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipitis
reviewed
Nov 1, 2025
| blocks[:] = [block.copy() for block in initial_blocks] | ||
| elif key == " ": | ||
| blocks.append( | ||
| [block_size // 2 + 10, block_size // 2 + 10, (255, 255, 255, 255)] |
There was a problem hiding this comment.
pressing space breaks, as this misses one element in the list. I think it should be [block_size // 2 + 10, block_size // 2 + 10, block_size, (255, 255, 255, 255)]
There was a problem hiding this comment.
Nice catch. I fixed it in #115.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example is very useful to determine whether the more advanced backends, like the Pyodide one, but also future remote backends and jupyter_rfb etc. actually are snappy.
Plus it demonstrates good practices for implementing dragging.