Skip to content

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Oct 8, 2025

Summary by CodeRabbit

  • Chores
    • Expanded official Python support to include 3.14.
    • Adjusted compatibility range to allow installation on Python 3.14 environments.
    • Updated package metadata to reflect broader interpreter support and ensure correct pip install behavior.
    • Improves compatibility checks during installation for users on newer Python versions.
    • No changes required for existing users on earlier supported versions.

Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Walkthrough

Updated Python version metadata in pyproject.toml: widened requires-python upper bound to <3.15 and added Python 3.14 to classifiers.

Changes

Cohort / File(s) Summary of Changes
Python version metadata
pyproject.toml
- Widened project.requires-python upper bound from <3.14 to <3.15
- Added Programming Language :: Python :: 3.14 to classifiers

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Increase minimum python version #737 — Also changes Python version constraints in pyproject.toml, modifying the lower bound operator; closely related to version requirement updates.

Poem

A whisk of versions, hop so light,
From 3.14 we take our flight—
Bounds extended, tidy and neat,
Metadata carrots, crisp and sweet.
Thump-thump! The release feels right,
Onward to builds that run just right. 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title “Test Python 3.14” suggests that the pull request is about adding or running tests against Python 3.14 rather than clearly indicating that the project’s Python compatibility has been updated to include version 3.14. It does not accurately summarize the main change, which is widening the required Python range and adding Python 3.14 to the classifiers. Therefore it risks misleading readers about the actual content of the PR. Please rename the title to something like “Add support for Python 3.14” or “Widen Python compatibility to <3.15 and include 3.14” so that it clearly reflects the changes made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Py314u

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e891eec and 5fcf715.

📒 Files selected for processing (1)
  • pyproject.toml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: notebooks_integration
  • GitHub Check: unittest_flux_openmpi
  • GitHub Check: benchmark (ubuntu-latest, 3.14, .ci_support/environment-mpich.yml)
  • GitHub Check: benchmark (ubuntu-latest, 3.14, .ci_support/environment-openmpi.yml)
  • GitHub Check: unittest_win
  • GitHub Check: unittest_slurm_mpich
  • GitHub Check: minimal
  • GitHub Check: unittest_flux_mpich
🔇 Additional comments (1)
pyproject.toml (1)

19-31: Verify Python 3.14 compatibility for pinned deps.

Automated checks failed due to SSL/script errors; please manually confirm that each version-pinned dependency in pyproject.toml (lines 19–31) publishes Python 3.14 support (requires_python and/or classifier) on PyPI before merging.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.16%. Comparing base (e891eec) to head (5fcf715).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #840   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          34       34           
  Lines        1688     1688           
=======================================
  Hits         1657     1657           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant