[fix] gather return_exception#7
Open
ausdavoud wants to merge 1 commit intopykeras:masterfrom
Open
Conversation
return_exception=True does not raise an exception; rather, aggregates it in the result list.
pykeras
requested changes
Jul 27, 2023
Owner
pykeras
left a comment
pykeras
left a comment
There was a problem hiding this comment.
Got your point, but removing it is not a good Idea it would be better to add better exception handling (definitely need work) : As an example we may need to report a list of urls with exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return_exception=True does not raise an exception;
Rather, aggregates it in the result list.