Skip to content

Restore tests for ByteString in 3.14 - #2829

Merged
cdce8p merged 1 commit into
pylint-dev:mainfrom
cdce8p:byte-string
Sep 23, 2025
Merged

Restore tests for ByteString in 3.14#2829
cdce8p merged 1 commit into
pylint-dev:mainfrom
cdce8p:byte-string

Conversation

@cdce8p

@cdce8p cdce8p commented Sep 22, 2025

Copy link
Copy Markdown
Member

Ref #2747

The removal of typing.ByteString and collections.abc.ByteString was reverted in Python 3.14.0rc3. They are now scheduled for removal in Python 3.17. Restore the test cases.
https://docs.python.org/3.14/library/typing.html#typing.ByteString

@cdce8p cdce8p added Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.14 labels Sep 22, 2025
@cdce8p

cdce8p commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

Not sure if this should be backported. The original PR was. Though this likely depends on our planned release schedule for astroid and pylint.

@codecov

codecov Bot commented Sep 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.35%. Comparing base (97f4837) to head (e7a9e5b).
⚠️ Report is 79 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2829   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files          91       91           
  Lines       11113    11113           
=======================================
  Hits        10375    10375           
  Misses        738      738           
Flag Coverage Δ
linux 93.22% <ø> (ø)
pypy 93.35% <ø> (ø)
windows 93.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/brain/brain_typing.py 88.95% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pierre-Sassoulas

Copy link
Copy Markdown
Member

We're going to release astroid 4.0 soon and afair we released the last 3.x already.

@cdce8p cdce8p added this to the 4.0.0 milestone Sep 23, 2025
@cdce8p

cdce8p commented Sep 23, 2025

Copy link
Copy Markdown
Member Author

We're going to release astroid 4.0 soon and afair we released the last 3.x already.

👍🏻 Let's not backport it then.

@cdce8p
cdce8p merged commit e3f5fb5 into pylint-dev:main Sep 23, 2025
21 checks passed
@cdce8p
cdce8p deleted the byte-string branch September 23, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.14

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants