Skip to content

[Backport maintenance/3.3.x] Improve backport job permissions #10391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 18, 2025

Backport 222ab20 from #10390.

Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (5fce790) to head (f30c749).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           maintenance/3.3.x   #10391   +/-   ##
==================================================
  Coverage              95.84%   95.84%           
==================================================
  Files                    174      174           
  Lines                  18995    18995           
==================================================
  Hits                   18206    18206           
  Misses                   789      789           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible, no more close/open to do 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit 5addaaa into maintenance/3.3.x May 18, 2025
23 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-10390-to-maintenance/3.3.x branch May 18, 2025 11:09
@cdce8p
Copy link
Member Author

cdce8p commented May 18, 2025

Incredible, no more close/open to do 😄

Seems I missed on detail 😅 All backport PRs are created in my name since I own the PAT. Maybe we should have a bot for it.

@Pierre-Sassoulas
Copy link
Member

Before that it was "github-actions / bot " (#10315)

@cdce8p
Copy link
Member Author

cdce8p commented May 18, 2025

Before that it was "github-actions / bot " (#10315)

Yeah. With PAT we need an owner for it though.

@cdce8p
Copy link
Member Author

cdce8p commented May 18, 2025

Just created the pylint-dev-bot let's hope everything still works 🤞🏻

@Pierre-Sassoulas
Copy link
Member

Nice, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants