Skip to content

Conversation

@Seggan
Copy link
Member

@Seggan Seggan commented Feb 11, 2026

  • Adds context file to config errors
  • Improves error messages within config adapters
  • Improves config adapter code in general

Before:

java.lang.ExceptionInInitializerError
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.guide.pages.settings.BlockTextureSettingsPage.<clinit>(BlockTextureSettingsPage.kt:14) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.guide.pages.settings.ResourcePackSettingsPage.<clinit>(ResourcePackSettingsPage.kt:13) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.guide.pages.settings.MainSettingsPage.<clinit>(MainSettingsPage.kt:18) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.content.guide.RebarGuide.<clinit>(RebarGuide.kt:140) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.Rebar.onEnable(Rebar.kt:140) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:279) ~[paper-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:639) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:596) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:321) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1260) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:388) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.lang.IllegalArgumentException: Failed to convert value 'MemorySection[path='custom-block-textures.culling.presets', root='YamlConfiguration']' to type java.util.Map<java.lang.String, io.github.pylonmc.rebar.resourcepack.block.CullingPreset> for key 'custom-block-textures.culling.presets' in section ''
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.ConfigSection.getOrThrow(ConfigSection.kt:77) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.RebarConfig$BlockTextureConfig.<clinit>(RebarConfig.kt:147) ~[?:?]
	... 15 more
Caused by: java.lang.IllegalArgumentException: Culling preset is missing 'index' field
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.adapter.CullingPresetConfigAdapter.convert(CullingPresetConfigAdapter.kt:12) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.adapter.CullingPresetConfigAdapter.convert(CullingPresetConfigAdapter.kt:6) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.adapter.MapConfigAdapter.convert(MapConfigAdapter.kt:21) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.adapter.MapConfigAdapter.convert(MapConfigAdapter.kt:16) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.adapter.MapConfigAdapter.convert(MapConfigAdapter.kt:7) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.ConfigSection.getOrThrow(ConfigSection.kt:75) ~[?:?]
	... 16 more

After:

java.lang.ExceptionInInitializerError
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.guide.pages.settings.BlockTextureSettingsPage.<clinit>(BlockTextureSettingsPage.kt:14) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.guide.pages.settings.ResourcePackSettingsPage.<clinit>(ResourcePackSettingsPage.kt:13) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.guide.pages.settings.MainSettingsPage.<clinit>(MainSettingsPage.kt:18) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.content.guide.RebarGuide.<clinit>(RebarGuide.kt:140) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.Rebar.onEnable(Rebar.kt:140) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:279) ~[paper-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:639) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:596) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:321) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1260) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:388) ~[paper-1.21.11.jar:1.21.11-69-94d0c97]
	at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: io.github.pylonmc.rebar.config.ConfigSection$KeyNotFoundException: Key 'custom-block-textures.culling.presets.disabled.index' not found in config file /home/seggan/Progs/Kotlin/pylonmc/run/plugins/Rebar/config.yml
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.ConfigSection.getOrThrow(ConfigSection.kt:73) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.adapter.CullingPresetConfigAdapter.convert(CullingPresetConfigAdapter.kt:12) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.adapter.CullingPresetConfigAdapter.convert(CullingPresetConfigAdapter.kt:6) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.adapter.MapConfigAdapter.convert(MapConfigAdapter.kt:21) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.adapter.MapConfigAdapter.convert(MapConfigAdapter.kt:16) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.adapter.MapConfigAdapter.convert(MapConfigAdapter.kt:7) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.ConfigSection.getOrThrow(ConfigSection.kt:75) ~[?:?]
	at rebar-1.0.0-SNAPSHOT.jar//io.github.pylonmc.rebar.config.RebarConfig$BlockTextureConfig.<clinit>(RebarConfig.kt:147) ~[?:?]
	... 15 more

Copy link
Contributor

@LordIdra LordIdra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Not thoroughly reviewed all code but changes look good at a high level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants