Skip to content

fix LinAlgError in HSGP-Basic.ipynb, drop find_constrained_prior #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Armatron44
Copy link

@Armatron44 Armatron44 commented Jul 27, 2025

Fixes #800. In addition, I spotted that the to be depreciated find_constrained_prior was still being used in the linearized HSGP model example, so I switched for the preliz max_ent approach.

I've specified the number of chains to run to match old version of notebook (my old pc will only run 2 by default). I also suppressed some user warnings from matplotlib by dropping calls to plt.tight_layout and plt.subplots_adjust.

{Insert Description}

Helpful links


📚 Documentation preview 📚: https://pymc-examples--801.org.readthedocs.build/en/801/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; good catch @Armatron44 !
I'll give @bwengals a few hours before merging, in case he wants to add something, but the stabilization of the covariance matrix looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinAlgError: Matrix is not positive definite error when generating fake data in HSGP-Basic
2 participants