Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional import of zarr #7645

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

lucianopaz
Copy link
Contributor

@lucianopaz lucianopaz commented Jan 14, 2025

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7645.org.readthedocs.build/en/7645/

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.77%. Comparing base (671d704) to head (ac9ef0a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pymc/backends/zarr.py 66.66% 6 Missing ⚠️
pymc/sampling/mcmc.py 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7645      +/-   ##
==========================================
+ Coverage   87.41%   92.77%   +5.36%     
==========================================
  Files         107      107              
  Lines       18168    18178      +10     
==========================================
+ Hits        15881    16865     +984     
+ Misses       2287     1313     -974     
Files with missing lines Coverage Δ
pymc/sampling/mcmc.py 87.14% <50.00%> (-0.31%) ⬇️
pymc/backends/zarr.py 93.81% <66.66%> (-1.86%) ⬇️

... and 9 files with indirect coverage changes

@ricardoV94 ricardoV94 added the no releasenotes Skipped in automatic release notes generation label Jan 14, 2025
@ricardoV94
Copy link
Member

Putting no release notes as we haven't released yet and it would look confusing in the release notes

@ricardoV94 ricardoV94 merged commit bd519d4 into pymc-devs:main Jan 14, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug maintenance no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zarr is not optional
2 participants