-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove abstract requirement of data_setter #1463
base: main
Are you sure you want to change the base?
Conversation
Looking at how the customer choice model uses this, I am second guessing. For instance, if there is in sample posterior predictive then this wouldn't really make sense. However, X is always required for the method at the moment. So maybe it makes sense... What are people thoughts? |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
- Coverage 92.73% 92.72% -0.02%
==========================================
Files 52 52
Lines 6114 6113 -1
==========================================
- Hits 5670 5668 -2
- Misses 444 445 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks @wd60622 ! |
Description
I've removed the implementation for the CLV classes since the
sample_posterior_predictive
methods are not used in those models.CC: @ColtAllen
Related Issue
Checklist
pre-commit.ci autofix
to auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1463.org.readthedocs.build/en/1463/