-
Notifications
You must be signed in to change notification settings - Fork 299
Break ModelBuilder into smaller classes #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
===========================================
- Coverage 92.20% 19.76% -72.44%
===========================================
Files 63 63
Lines 7312 7331 +19
===========================================
- Hits 6742 1449 -5293
- Misses 570 5882 +5312 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -165,55 +163,13 @@ def _fit_DEMZ(self, **kwargs) -> az.InferenceData: | |||
return pm.sample(step=pm.DEMetropolisZ(), **sampler_config) | |||
|
|||
@classmethod | |||
def load(cls, fname: str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1356 should be considered for the load
method replacing this.
Resolved merge conflicts to resume work on this because it overlaps with #1377, #1356, and #1380. @williambdean Do you anticipate the Bass module inheriting from |
Thanks!
Maybe |
Description
Splitting the original ModelBuilder into base class which then supports ModelBuilder and RegressionModelBuilder
Work in progress. Likely very broken at the moment
Related Issue
load
withModelBuilder
classmethod #1380Checklist
pre-commit.ci autofix
to auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1467.org.readthedocs.build/en/1467/