Skip to content

Break ModelBuilder into smaller classes #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented Feb 4, 2025

Description

Splitting the original ModelBuilder into base class which then supports ModelBuilder and RegressionModelBuilder

Work in progress. Likely very broken at the moment

Related Issue

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1467.org.readthedocs.build/en/1467/

@github-actions github-actions bot added CLV MMM tests ModelBuilder Related to the ModelBuilder class and its children customer choice Related to customer choice module labels Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

❌ Patch coverage is 55.55556% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.76%. Comparing base (4e0487a) to head (63cad51).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/model_builder.py 54.68% 58 Missing ⚠️
pymc_marketing/clv/models/basic.py 33.33% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4e0487a) and HEAD (63cad51). Click for more details.

HEAD has 22 uploads less than BASE
Flag BASE (4e0487a) HEAD (63cad51)
23 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1467       +/-   ##
===========================================
- Coverage   92.20%   19.76%   -72.44%     
===========================================
  Files          63       63               
  Lines        7312     7331       +19     
===========================================
- Hits         6742     1449     -5293     
- Misses        570     5882     +5312     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -165,55 +163,13 @@ def _fit_DEMZ(self, **kwargs) -> az.InferenceData:
return pm.sample(step=pm.DEMetropolisZ(), **sampler_config)

@classmethod
def load(cls, fname: str):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1356 should be considered for the load method replacing this.

@ColtAllen
Copy link
Collaborator

Resolved merge conflicts to resume work on this because it overlaps with #1377, #1356, and #1380.

@williambdean Do you anticipate the Bass module inheriting from ModelBuilder in the future?

@williambdean
Copy link
Contributor Author

Resolved merge conflicts to resume work on this because it overlaps with #1377, #1356, and #1380.

Thanks!

@williambdean Do you anticipate the Bass module inheriting from ModelBuilder in the future?

Maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV customer choice Related to customer choice module MMM ModelBuilder Related to the ModelBuilder class and its children tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants