Fix/replace deprecated budget method

[caiquefortunato]

Description

This PR updates the test test_allocate_budget_to_maximize_response_bad_noise_level by replacing the usage of the deprecated method allocate_budget_to_maximize_response with the recommended optimize_budget method.

This aligns the codebase with the current API and avoids suppressing DeprecationWarnings, as discussed in issue #1598 and the feedback on PR #1603.

Related Issue

• Closes #
• Related to Use optimize_budget method instead in tests #1598

Checklist

• [ x ] Checked that the pre-commit linting/style checks pass. Feel free to comment pre-commit.ci autofix to auto-fix.
• Included tests that prove the fix is effective or that the new feature works
• [ x ] Added necessary documentation (docstrings and/or example notebooks) using numpydoc format.
• [ x ] If you are a pro: each commit corresponds to a relevant logical change

---

📚 Documentation preview 📚: https://pymc-marketing--1604.org.readthedocs.build/en/1604/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (a87f1fa) to head (c0e3894).
Report is 81 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (a87f1fa) and HEAD (c0e3894). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (a87f1fa)	HEAD (c0e3894)
	23	21

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1604       +/-   ##
===========================================
- Coverage   93.53%   72.40%   -21.13%     
===========================================
  Files          55       55               
  Lines        6357     6357               
===========================================
- Hits         5946     4603     -1343     
- Misses        411     1754     +1343     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cetagostini]

Hey @caiquefortunato thank you for the PR. Everything looks good 👍

[cetagostini]

Let's wait for the test to pass before merge but code looks okay!

[cetagostini]

Sorry, I came back from work and see that the current solutions its not enough. Would be great, and we can support you if you need a hand to work on it.

[cetagostini]

Sorry, reading this better. Here we are doing the wrong fix. We should:

1. Replace all the suite (not only this test) to work with the new class.
2. We need to test the same scenarios, meaning, you need to test optimize budget and sample_response_distribution
3. No parameters should be delete, the test should be handle differently.
4. We need test for the method to be deprecated, and the new one. This because we still will hold the old method for at least one more release. So, best way should be to have test for both, and be sure non of them is doing something funny. IF we don't want to do this then we should deprecated already the old method. @williambdean Whats your take?