Support pymupdf_layout #4748
Merged
Support pymupdf_layout #4748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorjMcKie
force-pushed
the
layout2
branch
5 times, most recently
from
d33cdac to
4578a8f
Compare
julian-smith-artifex-com
requested changes
Oct 20, 2025
There was a problem hiding this comment.
As mentioned elsewhere, i'm worried that this PR adds a large amount of C code, some of which is unsafe if mupdf or C++ exceptions are thrown.
If we are sure that all this C code is required for speed reasons, then that's ok, but we need to fix the various resource cleanup issues i think.
JorjMcKie
force-pushed
the
layout2
branch
2 times, most recently
from
b9c370c to
347d10b
Compare
JorjMcKie
force-pushed
the
layout2
branch
2 times, most recently
from
0254384 to
805e066
Compare
|
Thanks for the various updates. One last thing: the patch has three trivial whitespace changes to files in the tests/ directory. I think it would be worthwhile removing these changes, then the patch can be trivially seen to not make any changes to our test suite. |
julian-smith-artifex-com
approved these changes
Oct 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely new version